fix(hmr): wait for import.meta.hot.prune callbacks to complete before running other HMRs
#20698
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re running other HMRs
sapphi-red
added
feat: hmr
p2-edge-case
hi-ogawa
approved these changes
Aug 30, 2025
bluwy
reviewed
Sep 1, 2025
| paths.map((path) => { | ||
| const fn = this.pruneMap.get(path) | ||
| if (fn) { | ||
| fn(this.dataMap.get(path)) |
There was a problem hiding this comment.
Suggested change
| fn(this.dataMap.get(path)) | |
| return fn(this.dataMap.get(path)) |
Shouldn't this need to return the promise?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I don't have any concrete case that requires this, but I think this should wait here.