feat: add isSsrTargetWebWorker flag to configEnvironment hook
#18620
+20
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
I think this is ok for v6. Do you know how we can get out of it? Do we need another option so this hack isn't needed?
Edit: oh, IIUC, we could just remove it once v5 support is no longer needed. Talking about that, I wonder if svelte will end up doing a clean cut and require Vite 6 soon after we release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
isSsrTargetWebWorkerflag toconfigEnvironmenthook so that plugins can supportssr.target: 'webworker'correctly.For example, this
configEnvironmenthook from sveltejs/vite-plugin-svelte#1020 needs to know ifssr.target: 'webworker'is set.https://github.com/sveltejs/vite-plugin-svelte/blob/dcec9afa2a9b1bfd5fe8f0767cc871a2b144a9d6/packages/vite-plugin-svelte/src/index.js#L71-L81
https://discord.com/channels/804011606160703521/1304311237332697098/1304350474085859338