New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support import string in router.add_router #1256

Merged

vitalik merged 2 commits into vitalik:master from engine2net:add-router-as-path-string

Aug 5, 2024

Contributor

martinsvoboda commented Aug 5, 2024

Added support for importing nested router with string path. This unifies behaviour with api.add_router:

# api.add_router
api = NinjaAPI()
api.add_router("main", "myproject.app1.router")

# router.add_router
router = Router()
router.add_router("nested", "myproject.app1.nested.router")

martinsvoboda added 2 commits

August 5, 2024 16:51


          Support router.add_router with import string

bf21aec


          Fix ruff

c25b7eb

vitalik merged commit 3c55d99 into vitalik:master

27 checks passed

Owner

vitalik commented Aug 5, 2024

Thank you @martinsvoboda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet