Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add union type and subtypes check in schema model signature #1242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add union type and subtypes check in schema model signature #1242

wants to merge 1 commit into from

Conversation

fazeelghafoor
Copy link

Fixes #1153 Add support for union type field in model schema

@fazeelghafoor
Copy link
Author

@vitalik can you please review and let me know if anything needs to be modified. I think this is a partial fix to #1153 but I felt like at least add support for UnionTypes.

@fazeelghafoor fazeelghafoor changed the title add union type and subtypes check in schema model signature Add union type and subtypes check in schema model signature Jul 29, 2024
@vitalik
Copy link
Owner

vitalik commented Aug 10, 2024

Could you also add some unit tests for this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Using pydantic.Json[SomeModel] in a query param fails
2 participants
@fazeelghafoor @vitalik