Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generic filter types #1212

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Allow generic filter types #1212

merged 1 commit into from
Aug 10, 2024

Conversation

eugenenelou
Copy link
Contributor

@eugenenelou eugenenelou commented Jun 28, 2024

This MR allows creating custom filter type with pydantic to reuse across filter classes, by making the field_name implicit.

like:

IContainsField = Annotated[Optional[str], Field(None, q='__icontains')]

class BookFilterSchema(FilterSchema):
    name: IContainsField

@eugenenelou
Copy link
Contributor Author

fixed the ruff and mypy errors.

@vitalik vitalik merged commit 6de2bdc into vitalik:master Aug 10, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants