This repository was archived by the owner on Jul 29, 2019. It is now read-only.
feat: added the ability to set the size of an icon when using a dot s…#4220
Open
jamespcole wants to merge 1 commit intovisjs:developfrom
Open
feat: added the ability to set the size of an icon when using a dot s…#4220jamespcole wants to merge 1 commit intovisjs:developfrom
jamespcole wants to merge 1 commit intovisjs:developfrom
Conversation
|
Code is LGTM. It would increase a chance to get merged if new option is added to |
mojoaxel
suggested changes
Jan 10, 2019
Member
mojoaxel
left a comment
There was a problem hiding this comment.
@jamespcole Thanks! But I have some questions:
- There is already a
icon.sizeoption. Is this not enough? - Every new option needs to be documented in the docs as well. somewhere near here
- If you still think this feature is needed could you please extend the icons example
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small change allowing the icon size to be scaled relative to the node when using the dot shape.
The existing "icon.size" property is ignored when using a "dot" shape so this new option is intended to enable specifying the icon size relative to the shape size.
To use this a "scale" setting can be added to the icon settings:
Thank you for contributing to vis.js!!
Please make sure to check the following requirements before creating a pull request:
masterbranch will be closed!git fetch && git rebase origin developto update your feature branch).fixes #1781in your git commit message this issue gets closed automatically by merging your pull request).