Skip to content
This repository was archived by the owner on Jul 29, 2019. It is now read-only.

Add Polygon shape with variable amount of sides#4205

Open
Jefwillems wants to merge 3 commits intovisjs:developfrom
Jefwillems:develop
Open

Add Polygon shape with variable amount of sides#4205
Jefwillems wants to merge 3 commits intovisjs:developfrom
Jefwillems:develop

Conversation

@Jefwillems
Copy link

  • Provide an additional or update an example to demonstrate your changes or new features.
  • Update the documentation if you introduced new behavior or changed existing behavior.
  • I didn't update the documentation yet because i am expecting to make more changes to the bounding boxes/sizes.
  • This issue asked for diamond shapes with the label inside, this is possible now with options: {sides:4, shape:'polygon'}
  • Expect review comments and change requests by reviewer.
  • Please inspect the behaviour i added to the network basicUsage.html example, i believe i'm doing something off with the sizes/boundingbox
  • Delete this checklist from your pull request.
    🙃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants