Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed NaN :rate and 0.0 :eta when curr is set. #212

Closed
wants to merge 1 commit into from
Closed

Fixed NaN :rate and 0.0 :eta when curr is set. #212

wants to merge 1 commit into from

Commits on Sep 30, 2021

  1. Fixed NaN :rate and 0.0 :eta when curr is set. 

    - Setting the current progress index to anything other than `0` will cause the value of `this.start` to be undefined. This causes the calculation for `:eta` and `:rate` to produce useless information.
    - Replaced conditional to set `start` only when the progress is ticked when `current` == 0.
    - We will always set the `start` time on first tick anyway.
    Francis Okoyo committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    78d2688 View commit details
    Browse the repository at this point in the history