Fixed NaN :rate and 0.0 :eta when curr is set.
#212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Setting the current progress index to anything other than `0` will cause the value of `this.start` to be undefined. This causes the calculation for `:eta` and `:rate` to produce useless information.
- Replaced conditional to set `start` only when the progress is ticked when `current` == 0.
- We will always set the `start` time on first tick anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0will cause the value ofthis.startto be undefined. This causes the calculation for:etaand:rateto produce useless information.startonly when the progress is ticked whencurrent== 0.starttime on first tick anyway.This PR should resolve and close #159