fix(engine): Prevent duplicate context creation in React #2485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented against
9.2-releaseBackground
Using luma in an React environment with StrictMode causes the
getMaxDrawingBufferSize()method in canvas-context to be called twice, once with and invalid device, leading to a error (repeated whenever the DOM node is remounted):Change List
this.canvasContext.destroy()inwebgl-device.tsto cleanup orphaned canvascanvas-context.tshello-reacttutorial app to repro bug and help test React integration in future