Skip to content

Comments

fix(core): shader-based globe occlusion for billboard layers (IconLayer, TextLayer)#10018

Closed
Copilot wants to merge 1 commit intoclaude/fix-deck-rendering-issues-XAMSdfrom
copilot/sub-pr-9975
Closed

fix(core): shader-based globe occlusion for billboard layers (IconLayer, TextLayer)#10018
Copilot wants to merge 1 commit intoclaude/fix-deck-rendering-issues-XAMSdfrom
copilot/sub-pr-9975

Conversation

Copy link
Contributor

Copilot AI commented Feb 20, 2026

Remove ArcLayer


Note

Low Risk
No actual modifications were observable from the supplied diff, so functional risk appears low (but re-check the full diff in GitHub to confirm).

Overview
The provided full_diff appears empty/invalid (only shows +++ /dev/null with no file context), so no concrete code changes could be determined from this PR content.

Written by Cursor Bugbot for commit b68a8d3. This will update automatically on new commits. Configure here.

Copilot AI changed the title [WIP] Fix shader-based globe occlusion for layers fix(core): shader-based globe occlusion for billboard layers (IconLayer, TextLayer) Feb 20, 2026
@charlieforward9
Copy link
Collaborator

@copilot partial layer depthtesting?

@charlieforward9 charlieforward9 marked this pull request as ready for review February 20, 2026 13:34
Copy link
Contributor Author

Copilot AI commented Feb 20, 2026

@copilot partial layer depthtesting?

Depth testing doesn't work correctly for billboard layers (IconLayer, TextLayer) even when enabled per-layer. The reason: billboard vertices use screen-space pixel offsets via project_pixel_size_to_clipspace — the anchor point may be behind the globe, but its screen-space-offset fragments end up at a depth value that passes the depth test since there's nothing in the depth buffer at those pixels. That's why shader-based occlusion at the anchor position is needed for billboards.

For non-billboard geometry like ArcLayer, regular depth testing does work — in interleaved mode the basemap provides a globe-shaped depth buffer that correctly occludes arcs going behind the globe, which is why ArcLayer was removed from scope.

@charlieforward9 charlieforward9 linked an issue Feb 20, 2026 that may be closed by this pull request
7 tasks
@chrisgervang chrisgervang force-pushed the claude/fix-deck-rendering-issues-XAMSd branch from 458ff97 to 7d342b7 Compare February 20, 2026 16:33
@chrisgervang chrisgervang deleted the copilot/sub-pr-9975 branch February 20, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Icon Layer on Globe Projection

3 participants