fix(geo-layers): adapt WMSLayer to @loaders.gl/wms v4.4 API#10013
Closed
charlieforward9 wants to merge 3 commits intovisgl:masterfrom
Closed
fix(geo-layers): adapt WMSLayer to @loaders.gl/wms v4.4 API#10013charlieforward9 wants to merge 3 commits intovisgl:masterfrom
charlieforward9 wants to merge 3 commits intovisgl:masterfrom
Conversation
Bump all @loaders.gl/* dependencies from ^4.3.4 to ^4.4.0-alpha.12 across all modules, examples, website, and test apps. This tests loaders.gl v4.4 prerelease compatibility with deck.gl ahead of the official 4.4 release. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace deprecated createImageSource with direct WMSSource and ArcGISImageServerSource factory calls to fix build errors from the loaders.gl v4.4.0-alpha.12 bump. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
LoaderOptions is no longer assignable to StrictLoaderOptions in @loaders.gl v4.4 due to deprecated top-level fields conflicting with the index signature. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@loaders.glto v4.4.0-alpha.12 (includes changes from chore: bump @loaders.gl to v4.4.0-alpha.12 #10012)WMSLayercaused by breaking API changes in@loaders.gl/wms:ImageServiceTypeexport replaced with local type aliascreateImageSourcereplaced with directWMSSource.createDataSource()and_ArcGISImageServerSource.createDataSource()calls (no casts needed, both return properImageSourceimplementations)Test plan
test-nodepasses (was failing onmodules/geo-layersTypeScript build)test-websitepasses (same build error)