Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of ProviderFailed due to expected pod spec mismatch #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jeffwan
Copy link
Contributor

@Jeffwan Jeffwan commented Jan 25, 2021

Address #17

UpdatePod will be invoked in every loop because of following logic.

https://github.com/virtual-kubelet/virtual-kubelet/blob/bd742d5d99eafb0140f32def3b071028925d9dfa/node/pod.go#L75-L76

actual pod spec will always has service account token and default tolerance like node.kubernetes.io/not-ready:NoExecute.
Returning errNotImplemented make reconciler think this is a provider error so the pod status will be always ProviderFailed

Returning nil bring things back to normal

➜  k get pods
NAME                                READY   STATUS    RESTARTS   AGE
nginx-deployment-568c9ff59d-gzj6b   1/1     Running   0          8m42s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant