Skip to content

Fix/python file import extraction#8

Merged
jassem-manita merged 2 commits intomainfrom
fix/python-file-import-extraction
Feb 9, 2026
Merged

Fix/python file import extraction#8
jassem-manita merged 2 commits intomainfrom
fix/python-file-import-extraction

Conversation

@jassem-manita
Copy link
Collaborator

Description

Fixes #(issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • Improved import extraction for .py files (no longer treats each line as a requirement)
  • Fixed standard library detection logic (only true stdlib modules classified as such)
  • Now detects and offers to install missing third-party packages (e.g., matplotlib)

Testing

  • All existing tests pass
  • Manual testing performed

Test Commands Run

pytest tests/
flake8 midna/ tests/
black --check midna/ tests/

Code Quality Checklist

  • Code follows the project's style guidelines (Black, isort, Flake8)
  • Self-review of code completed
  • Code is commented where necessary
  • Docstrings added/updated (Google-style format)
  • No new warnings generated
  • Commit messages follow conventional commits format

Documentation

  • README updated (if needed)
  • CONTRIBUTING.md updated (if needed)
  • Docstrings updated
  • Comments added for complex logic

Checklist Before Merge

  • PR title follows conventional commits format
  • All CI checks pass
  • Code reviewed by at least one maintainer
  • Branch is up to date with main
  • No merge conflicts

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
midna/core.py 12.50% 7 Missing ⚠️
midna/package_classifier.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@jassem-manita jassem-manita merged commit a4084be into main Feb 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant