Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maui winui #370

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Maui winui #370

merged 3 commits into from
Jan 15, 2025

Conversation

mfkl
Copy link
Member

@mfkl mfkl commented Nov 14, 2024

Getting lots of these

DEP0900: Failed to unregister application "49861f9e-48d3-45c0-b6a8-f591ad6d2010_1.0.0.1_x64__9zz4h110yvjzm". [0x80073CFA] 

Unsure why. Impossible to uninstall existing appx that match this app ID.

On 3.x, on WinUI, the LibVLC object is built using string parameters retrieved from an initialized VideoView (see the plan WinUI sample code). Will have to re-work the code to handle this in the MAUI sample for WinUI support.

@jonx
Copy link
Contributor

jonx commented Nov 19, 2024

Have you tried to unregister the app manually?
In a powershell: Get-AppxPackage *49861f9e-48d3-45c0-b6a8-f591ad6d2010*
Then Remove-AppxPackage -Package full package name, in my case the full name is: 49861f9e-48d3-45c0-b6a8-f591ad6d2010_1.0.0.1_x64__9zz4h110yvjzm

@mfkl
Copy link
Member Author

mfkl commented Nov 25, 2024

Exception thrown at 0x00007FFA3639B699 (KernelBase.dll) in LibVLCSharp.MAUI.Sample.exe: WinRT originate error - 0x800F1000 : 'Cannot apply a Style with TargetType 'LibVLCSharp.Platforms.Windows.VideoViewBase' to an object of type 'Microsoft.UI.Xaml.Controls.Control'.'.
Microsoft.ui.xaml.dll!00007FF99E8243D2: 800F1000 - E_NER_INVALID_OPERATION

getting these also

@mfkl
Copy link
Member Author

mfkl commented Dec 10, 2024

Progress. Need to check that 267bf18 doesn't break other UI frameworks.

@mfkl
Copy link
Member Author

mfkl commented Dec 10, 2024

Without 267bf18, there are errors like

Exception thrown at 0x00007FFA3639B699 (KernelBase.dll) in LibVLCSharp.MAUI.Sample.exe: WinRT originate error - 0x800F1000 : 'Cannot apply a Style with TargetType 'LibVLCSharp.Platforms.Windows.VideoViewBase' to an object of type 'Microsoft.UI.Xaml.Controls.Control'.'.
Microsoft.ui.xaml.dll!00007FF99E8243D2: 800F1000 - E_NER_INVALID_OPERATION

With it, though, our windows video view initialization logic is broken since OnApplyTemplate never gets called. Reworking this view hierarchy would likely be a breaking change, for Uno, UWP and WinUI.

@mfkl
Copy link
Member Author

mfkl commented Dec 17, 2024

There is some exception when shutting down the Media Element sample, very little info with debugger attached..

Unhandled exception at 0x00007FF9580C6202 in LibVLCSharp.MAUI.Sample.MediaElement.exe: 0xC0000005: Access violation executing location 0x00007FF9580C6202

Not very insightful.

Logs:

Exception thrown at 0x00007FFA9B5FB699 (KernelBase.dll) in LibVLCSharp.MAUI.Sample.MediaElement.exe: WinRT originate error - 0x80000013 : 'The given object has already been closed / disposed and may no longer be used.'.
Exception thrown at 0x00007FFA9B5FB699 (KernelBase.dll) in LibVLCSharp.MAUI.Sample.MediaElement.exe: WinRT originate error - 0x80070005 : 'The caller is not allowed to perform this operation on this object.'.
The thread 'DManip Delegate Thread' (7800) has exited with code 0 (0x0).
Exception thrown at 0x00007FFA9B5FB699 in LibVLCSharp.MAUI.Sample.MediaElement.exe: Microsoft C++ exception: MONZA::DdiThreadingContext<MONZA::AdapterTraits_Gen12LP>::msg_end at memory location 0x00000065702BFD10.
The thread '0xc0550001' (23260) has exited with code 0 (0x0).
Exception thrown at 0x00007FFA9B5FB699 in LibVLCSharp.MAUI.Sample.MediaElement.exe: Microsoft C++ exception: MONZA::IgcThreadingContext<MONZA::AdapterTraits_Gen12LP>::msg_end at memory location 0x000000657013FDE0.
The thread '0x16c00001' (19672) has exited with code 0 (0x0).
Exception thrown at 0x00007FFA9B5FB699 (KernelBase.dll) in LibVLCSharp.MAUI.Sample.MediaElement.exe: 0x40080202: WinRT transform error (parameters: 0x000000008000000B, 0x0000000080070490, 0x0000000000000014, 0x000000656CB9D180).
Exception thrown at 0x00007FFA9B5FB699 (KernelBase.dll) in LibVLCSharp.MAUI.Sample.MediaElement.exe: 0x40080202: WinRT transform error (parameters: 0x000000008000000B, 0x0000000080070490, 0x0000000000000014, 0x000000656CB9D180).
The thread 21920 has exited with code 0 (0x0).
Exception thrown at 0x00007FF9580C6202 in LibVLCSharp.MAUI.Sample.MediaElement.exe: 0xC0000005: Access violation executing location 0x00007FF9580C6202.
Unhandled exception at 0x00007FF9580C6202 in LibVLCSharp.MAUI.Sample.MediaElement.exe: 0xC0000005: Access violation executing location 0x00007FF9580C6202.

There are similar logs in the non-MediaElement sample, but the process does exit properly.

@mfkl mfkl marked this pull request as ready for review December 19, 2024 16:45
@mfkl
Copy link
Member Author

mfkl commented Dec 19, 2024

Should be good enough for an initial release.

@mfkl mfkl requested a review from jeremyVignelles January 14, 2025 06:37
@mfkl
Copy link
Member Author

mfkl commented Jan 14, 2025

Potential breaking change in src/LibVLCSharp/Themes/Generic.xaml but no way around it, due to a MAUI/WinUI bug. Thoughts? @jeremyVignelles

Copy link
Collaborator

@jeremyVignelles jeremyVignelles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the breaking change should be quite rare given that we didn't document that style. In any case, the fix should be straightforward.

@vlc-mirrorer vlc-mirrorer merged commit 940c549 into videolan:3.x Jan 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants