Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media: Internally keep a reference to the last set Media #205

Closed
wants to merge 8 commits into from
Closed

Media: Internally keep a reference to the last set Media #205

wants to merge 8 commits into from
+43 −15

Commits on Jul 26, 2021

  1. Media: Internally keep a reference to the last set Media 

    libvlc_media_player_get_media increments the ref count of the media, which may easily
cause a memory leak, as this is very unusual behavior for C# property getter to
have these types of consequences. Users don't have the reflex to dispose every Media returned
by the getter property.

Holding a ref internally in the mediaplayer prevents from incrementing the native ref count
of the media object.

https://code.videolan.org/videolan/LibVLCSharp/-/issues/442
    @mfkl
    mfkl committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    1ad638f View commit details
    Browse the repository at this point in the history

  2. Tests: Adjust LibVLC API coverage to reflect libvlc_media_player_get_… 

    …media removal
    @mfkl
    mfkl committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    c3bab01 View commit details
    Browse the repository at this point in the history

  3. add media retain

    @mfkl
    mfkl committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    d1d0a89 View commit details
    Browse the repository at this point in the history

  4. Add native ref check

    @mfkl
    mfkl committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    84250eb View commit details
    Browse the repository at this point in the history

  5. fix add option media usage

    @mfkl
    mfkl committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    946ba50 View commit details
    Browse the repository at this point in the history

  6. Revert "Add native ref check" 

    This reverts commit 84250eb.
    @mfkl
    mfkl committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    fd809d2 View commit details
    Browse the repository at this point in the history

  7. nit

    @mfkl
    mfkl committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    ade26bd View commit details
    Browse the repository at this point in the history

  8. add failing test

    @mfkl
    mfkl committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    8503a4f View commit details
    Browse the repository at this point in the history