Fix cabin assignments showing under wrong festivals #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cabin assignments for upcoming festivals were incorrectly appearing under previous festivals when they shared the same site. This was caught by a user because they noticed a cabin assignment under VC3, which they did not attend, so they realized it was for VC4.
This happened because I goofed up some SQL in #41, which was an unnecessary change anyway, so this undoes that. The fix has us use
attendee.festival_idinstead offestival.festival_id, as was originally the case before PR #41 was merged a few days ago, and removes unnecessary joins that were also added in that PR.