Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP connection handler call: peerAddress added to the error message #47

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

denizzzka
Copy link
Contributor

@denizzzka denizzzka commented Nov 9, 2024

At the moment we don't see who is creating corrupted connections. I.e., if we try to run corrupted connection to the HTTPS port:

> telnet localhost 8351
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
dsf
Connection closed by foreign host.

Maximum detaled log will contain any info but not IP addresses:

[main(oway) dbg] Accept TLS connection: server
[main(oway) dbg] OpenSSL error at ../ssl/record/methods/tlsany_meth.c:80: error:0A00010B:SSL routines::wrong version number (-)
[main(oway) ERR] HTTP connection handler has thrown: Accepting SSL tunnel: error:0A00010B:SSL routines::wrong version number (167772427)
[main(oway) dbg] Full error: object.Exception@../../../.dub/packages/vibe-stream/1.1.0/vibe-stream/tls/vibe/stream/openssl.d(677): Accepting SSL tunnel: error:0A00010B:SSL routines::wrong version number (167772427)
[main(oway) dbg] ----------------
[main(oway) dbg] ??:? [0x556710f6a16e]
[...]

Proposed PR modifies LogError-level line to:

[main(o2we) ERR] HTTP connection handler has thrown at the peer 127.0.0.1:38352: Accepting SSL tunnel: error:0A00010B:SSL routines::wrong version number (167772427)

@denizzzka denizzzka marked this pull request as draft November 9, 2024 13:25
@denizzzka denizzzka force-pushed the tcp_level_error_details branch from d48ea87 to f4f4e50 Compare November 9, 2024 13:29
@denizzzka denizzzka marked this pull request as ready for review November 9, 2024 13:31
@denizzzka denizzzka force-pushed the tcp_level_error_details branch from f4f4e50 to 5d65ef8 Compare November 9, 2024 13:33
@s-ludwig s-ludwig merged commit d4f2619 into vibe-d:master Nov 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants