Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial attempt at QK100 support #781

Closed
wants to merge 2 commits into from

Conversation

TunaLobster
Copy link

This includes INSURE due to elimination of variables in the build process. Currently I am seeing a build issue of overflowing the flash by 6k. Not sure exactly what is causing that.

@TunaLobster TunaLobster marked this pull request as draft September 1, 2024 02:09
Comment on lines +3 to +85
"menus": [
{
"label":"Lighting",
"content": [
{
"label": "Per-key RGB",
"content": [
{
"label": "Brightness",
"type": "range",
"options": [0, 200],
"content": ["id_qmk_rgb_matrix_brightness", 3, 1]
},
{
"label": "Effect",
"type": "dropdown",
"content": ["id_qmk_rgb_matrix_effect", 3, 2],
"options": [
"All Off",
"Solid Color",
"Alphas Mods",
"Gradient Up/Down",
"Gradient Left/Right",
"Breathing",
"Band Sat.",
"Band Val.",
"Pinwheel Sat.",
"Pinwheel Val.",
"Spiral Sat.",
"Spiral Val.",
"Cycle All",
"Cycle Left/Right",
"Cycle Up/Down",
"Rainbow Moving Chevron",
"Cycle Out/In",
"Cycle Out/In Dual",
"Cycle Pinwheel",
"Cycle Spiral",
"Dual Beacon",
"Rainbow Beacon",
"Rainbow Pinwheels",
"Raindrops",
"Jellybean Raindrops",
"Hue Breathing",
"Hue Pendulum",
"Hue Wave",
"Pixel Rain",
"Pixel Flow",
"Pixel Fractal",
"Typing Heatmap",
"Digital Rain",
"Solid Reactive Simple",
"Solid Reactive",
"Solid Reactive Wide",
"Solid Reactive Multi Wide",
"Solid Reactive Cross",
"Solid Reactive Multi Cross",
"Solid Reactive Nexus",
"Solid Reactive Multi Nexus",
"Spash",
"Multi Splash",
"Solid Splash",
"Solid Multi Splash"
]
},
{
"showIf": "{id_qmk_rgb_matrix_effect} != 0",
"label": "Effect Speed",
"type": "range",
"options": [0, 255],
"content": ["id_qmk_rgb_matrix_effect_speed", 3, 3]
},
{
"showIf": "{id_qmk_rgb_matrix_effect} != 0 && {id_qmk_rgb_matrix_effect} != 24 && {id_qmk_rgb_matrix_effect} != 28 && {id_qmk_rgb_matrix_effect} != 29 && {id_qmk_rgb_matrix_effect} != 32",
"label": "Color",
"type": "color",
"content": ["id_qmk_rgb_matrix_color", 3, 4]
}
]
}
]
}
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"menus": [
{
"label":"Lighting",
"content": [
{
"label": "Per-key RGB",
"content": [
{
"label": "Brightness",
"type": "range",
"options": [0, 200],
"content": ["id_qmk_rgb_matrix_brightness", 3, 1]
},
{
"label": "Effect",
"type": "dropdown",
"content": ["id_qmk_rgb_matrix_effect", 3, 2],
"options": [
"All Off",
"Solid Color",
"Alphas Mods",
"Gradient Up/Down",
"Gradient Left/Right",
"Breathing",
"Band Sat.",
"Band Val.",
"Pinwheel Sat.",
"Pinwheel Val.",
"Spiral Sat.",
"Spiral Val.",
"Cycle All",
"Cycle Left/Right",
"Cycle Up/Down",
"Rainbow Moving Chevron",
"Cycle Out/In",
"Cycle Out/In Dual",
"Cycle Pinwheel",
"Cycle Spiral",
"Dual Beacon",
"Rainbow Beacon",
"Rainbow Pinwheels",
"Raindrops",
"Jellybean Raindrops",
"Hue Breathing",
"Hue Pendulum",
"Hue Wave",
"Pixel Rain",
"Pixel Flow",
"Pixel Fractal",
"Typing Heatmap",
"Digital Rain",
"Solid Reactive Simple",
"Solid Reactive",
"Solid Reactive Wide",
"Solid Reactive Multi Wide",
"Solid Reactive Cross",
"Solid Reactive Multi Cross",
"Solid Reactive Nexus",
"Solid Reactive Multi Nexus",
"Spash",
"Multi Splash",
"Solid Splash",
"Solid Multi Splash"
]
},
{
"showIf": "{id_qmk_rgb_matrix_effect} != 0",
"label": "Effect Speed",
"type": "range",
"options": [0, 255],
"content": ["id_qmk_rgb_matrix_effect_speed", 3, 3]
},
{
"showIf": "{id_qmk_rgb_matrix_effect} != 0 && {id_qmk_rgb_matrix_effect} != 24 && {id_qmk_rgb_matrix_effect} != 28 && {id_qmk_rgb_matrix_effect} != 29 && {id_qmk_rgb_matrix_effect} != 32",
"label": "Color",
"type": "color",
"content": ["id_qmk_rgb_matrix_color", 3, 4]
}
]
}
]
}
],

Vial doesn't recognize these objects, so they can just be removed,

@xyzz
Copy link
Contributor

xyzz commented Oct 27, 2024

there is no update for over a month, closing

@xyzz xyzz closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants