Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed label in "Tap Dance" tab #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

aciceri
Copy link

@aciceri aciceri commented Mar 5, 2022

"On tap + hold" actually means to double tap and hold.
I didn't start the application with this new label but the change looks harmless.

"On tap + hold" actually means to double tap and hold
@xyzz
Copy link
Contributor

xyzz commented Mar 6, 2022

Hm, I lifted these descriptions from ZSA configurator:

image

Though I see now that QMK docs use "double tap and hold" in their tap dance docs - https://docs.qmk.fm/#/feature_tap_dance?id=example-4 - so not sure which one is more accurate.

@aciceri
Copy link
Author

aciceri commented Mar 7, 2022

From a pragmatic stand I think that for the end user (like me yesterday) of this application it's much more intuitive reading "Double tap and hold". What should be the difference between "on hold" and "on tap + hold"?

However I understand the need to reflect the labels used upstream (in this case ambiguous).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants