Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image_batch: Create bash example. #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

image_batch: Create bash example. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions image_batch/convert_png_to_jpg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
#!/bin/bash

set -e

for source_file in *.png; do
common_name=$(basename $source_file '.png')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to support file containing spaces you should change this line to common_name=$(basename "$source_file" '.png') and the line 9 to convert "$source_file" "$dest_file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooo spaces. Gross but realistic. That's a good catch.

dest_file="${common_name}.jpg"
echo "converting $source_file to $dest_file"
convert $source_file $dest_file
done