Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy local reject files larger than buffer size #147

Merged
merged 2 commits into from
May 29, 2024

Conversation

sitingren
Copy link
Member

There is a nondeterministic test failure in copy-local-file-tests.js, which is caused by fs.appendFile() asynchronously append multiple WriteFile data to a reject file. Multiple WriteFile data should write to the reject file in order.

Copy link
Collaborator

@DMickens DMickens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Good fix

@sitingren sitingren merged commit ab2c8aa into vertica:master May 29, 2024
7 checks passed
@sitingren sitingren deleted the copy-bug branch May 29, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants