TLS verify-full fix host #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DMickens I found this bug and tested this PR within sqltools. You may consider change the tls test/framework in another PR. |
I'm not quite sure what we would do in the tests/framework differently. We don't really have the ability to not run against localhost. It can be tested manually. Regardless that was a good catch by you. I think most deployments do not have the server running locally, which means we probably don't have many users using verify-full TLS or this would have been reported sooner. |
DMickens
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connect to a remote server with tls_mode = 'verify-full', the client throws an error message
Hostname/IP does not match certificate's altnames: Host: localhost. is not in the cert's altnames: DNS:abc.example.com.This is because the nodejs tls module uses 'localhost' as the default host when checking the server's host name against the certificate. This PR takes the user input host (not DNS resolved or load balanced) and pass to the tls_options for verifying the certificate. This doesn't change the host the socket should connect to.