Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glob to package.json for 1.1.2 #135

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

DMickens
Copy link
Collaborator

@DMickens DMickens commented Feb 20, 2024

Fix #133

glob has been added to the yarn dependencies using yarn package manager interface yarn add glob.
vertica-nodejs 1.1.2 and v-pool 1.1.2 as it depends on vertica-nodejs version have been updated.

Yarn.lock is updated with glob dependencies, and reflects global configuration preference for npmjs.org over yarnpkg.com when available.

@sitingren
Copy link
Member

@DMickens Do you think the CI failure is introduced by your updates?

@DMickens
Copy link
Collaborator Author

@DMickens Do you think the CI failure is introduced by your updates?

It looks like one of the dependencies for that version of glob is using ECMAScript 2019 features which isn't supported by all of our node versions. I'll update the version of glob. I believe 7.1.6 should be supported by everything we claim to support. I'll push the changes and check the CI tests again

@DMickens
Copy link
Collaborator Author

@DMickens Do you think the CI failure is introduced by your updates?

It looks like one of the dependencies for that version of glob is using ECMAScript 2019 features which isn't supported by all of our node versions. I'll update the version of glob. I believe 7.1.6 should be supported by everything we claim to support. I'll push the changes and check the CI tests again

@sitingren That was the issue. It is updated and fixed now

@DMickens DMickens merged commit e2ee7df into vertica:master Feb 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing denpendency glob
2 participants