-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a restore point info in the vdb status #942
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After creating the vrep, could we collect the restore point's id and index and store it in vdb or somewhere? Then we remove the vrep so the user doesn't know we did a vrep creation.
Or we just call vclusterOps API to get the restore point's info rather than creating a vrep CR.
pkg/meta/annotations.go
Outdated
// a restore point. When this is false, after saving a restore point, the operator | ||
// will create a VerticaRestorePointsQuery in order to expose the restore point info | ||
// the user. | ||
SkipVRPQCreationAnnotation = "vertica.com/skip-restore-points-query-creation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this annotation? We should always create the VRep CR to collect the restore point's info for the user.
A few reasons why I did it this way:
|
I went a slightly different direction. I added a reconciler for show_restore_point. It will detect if show_restore_point is needed from the status and will update the status. |
This fetches a restore point info through the show_restore_points api, and saves it to the status so that the user can easily find it.