Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setup-prometheus-adapter #1012

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
c2d7603
add setup-prometheus-adapter
qindotguan Dec 23, 2024
b9e2bc9
sample servicemonitor and values
HaoYang0000 Dec 24, 2024
f39bfb2
update make file
HaoYang0000 Dec 24, 2024
1c25379
update sample service monitor
HaoYang0000 Dec 25, 2024
6cf5e69
update example values
HaoYang0000 Dec 25, 2024
dd38f92
create script
HaoYang0000 Dec 26, 2024
b8b2110
update make file
HaoYang0000 Dec 26, 2024
1682e71
remove template file
HaoYang0000 Dec 26, 2024
5c3da03
remove unused content
HaoYang0000 Dec 26, 2024
4cd1754
address comments
HaoYang0000 Dec 26, 2024
593441a
add interval in scrpits and fix bug in namespace
HaoYang0000 Dec 26, 2024
b83799f
add namespace in undeploy
HaoYang0000 Dec 26, 2024
5d8c464
add vdb namespace customize
HaoYang0000 Dec 26, 2024
b0b6b88
revert change
HaoYang0000 Dec 26, 2024
aabad14
revert make file changes
HaoYang0000 Jan 2, 2025
1006b9a
update default values
HaoYang0000 Jan 2, 2025
e878ad6
move values file to prometheus directory
HaoYang0000 Jan 2, 2025
5e260c8
update file path
HaoYang0000 Jan 2, 2025
825cbbc
add e2e test
HaoYang0000 Jan 2, 2025
d1a9398
address comments
HaoYang0000 Jan 2, 2025
bbbe46b
Update Makefile
HaoYang0000 Jan 3, 2025
cabbde9
update e2e test
HaoYang0000 Jan 3, 2025
1e4d33b
rename dbname to vdbname in script
HaoYang0000 Jan 3, 2025
dd194a6
update script with cmd instead of cat f
HaoYang0000 Jan 3, 2025
4e9ca4e
add label for secret
HaoYang0000 Jan 3, 2025
9aa2428
assert service as well in e2e check
HaoYang0000 Jan 3, 2025
cfc65ca
add cr deletetion and fix namespace issue
HaoYang0000 Jan 3, 2025
1910af9
fix namespace issue
HaoYang0000 Jan 3, 2025
da6aea4
fix _
HaoYang0000 Jan 3, 2025
22e4958
add undeploy-prometheus-adapter
qindotguan Jan 3, 2025
e53300b
Merge branch 'deploy-prometheus' into qguan/setup-prometheus-adapter
qindotguan Jan 6, 2025
57ae07c
deploy with configuration file adapter.yaml
qindotguan Jan 6, 2025
7df6b27
correct the tabs
qindotguan Jan 6, 2025
22c2a63
Merge branch 'main' into qguan/setup-prometheus-adapter
qindotguan Jan 6, 2025
9756feb
add prometheus-adapter back after merge
qindotguan Jan 6, 2025
a2c953a
remove prometheustest as it renamed
qindotguan Jan 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,12 @@ else
exit 1
endif

.PHONY: setup-prometheus-adapter
setup-prometheus-adapter: ## Setup prometheus adapter for VerticaAutoscaler
helm repo add prometheus-community https://prometheus-community.github.io/helm-charts
helm repo update
helm install prometheus-adapter prometheus-community/prometheus-adapter --namespace monitoring --create-namespace
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the release name and namespace a parameter. Default release name and namespace can be prometheus-adapter.

  • There must be an undeploy command too
  • The user must be able to set the prometheus url, prometheus port , the number of replicas.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add PROMETHEUS_ADAPTER_NAME and PROMETHEUS_ADAPTER_NAMESPACE
  • added undeploy-prometheus-adapter
  • added example values with --set prometheus.url, --set prometheus.port, and --set replicas. I will make them configurable later


.PHONY: setup-minio
setup-minio: install-cert-manager install-kuttl-plugin ## Setup minio for use with the e2e tests
scripts/setup-minio.sh
Expand Down
Loading