Remember failures when collecting initial information in cluster/replication/sentinel #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladicek
force-pushed
the
cluster-replication-initial-info-failures
branch
from
2bee43d to
2738f53
Compare
Ladicek
changed the title
…ication/sentinel In the cluster, replication and sentinel modes, the first thing we do is iterate through known nodes and for each, connect and send a command to collect some information, until we obtain a successful response. This commit makes sure we remember the failures and when no successful response is ever obtained, we can complete the connection `Future` with an error message that contains the actual failures and not just a placeholder string.
Ladicek
force-pushed
the
cluster-replication-initial-info-failures
branch
from
2738f53 to
627ec65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the cluster, replication and sentinel modes, the first thing we do is iterate through known nodes and for each, connect and send a command to collect some information, until we obtain a successful response.
This commit makes sure we remember the failures and when no successful response is ever obtained, we can complete the connection
Futurewith an error message that contains the actual failures and not just a placeholder string.