Trying to fix - https://github.com/vert-x/mod-rxvertx/issues/39 #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Guys,
I am connecting to a server with self-signed cert on SSL, which causes SSL Handshake Exception.
In a vertx world, javax.net.ssl.SSLHandshakeException are handled by the exception handler attached to "HttpClient", not by the exception handler that's attached to "HttpClientRequest". I am proposing following change in RxHttpClient to handle it.
this.core.exceptionHandler(new Handler() {
@OverRide
public void handle(Throwable event) {
rh.fail(event);
}
});