Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to fix - https://github.com/vert-x/mod-rxvertx/issues/39 #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manish-panwar
Copy link

Hey Guys,

I am connecting to a server with self-signed cert on SSL, which causes SSL Handshake Exception.

In a vertx world, javax.net.ssl.SSLHandshakeException are handled by the exception handler attached to "HttpClient", not by the exception handler that's attached to "HttpClientRequest". I am proposing following change in RxHttpClient to handle it.

this.core.exceptionHandler(new Handler() {
@OverRide
public void handle(Throwable event) {
rh.fail(event);
}
});

@petermd
Copy link
Contributor

petermd commented Jan 25, 2016

this seems like a bug in Vert.x if it can happy on a per-request basis but the error is at the client level.

i think you'd need a better way to map the error to only the request that failed, unless it can be assumed that all requests must fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants