Fix printing of literals in fortran modes #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tueda
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
I never fully understood what the old code did, but the new code is understandable!
For now, I think the code looks fine as a minimal fix (except for the comment). But if we want to make sure PFortran mode works correctly in future, 4294967296/4294967297 should be output like (one*2*2147483647+2)/(one*2*2147483647+3) instead of the broken ((one*4294967296.D0)/4294967297.D0) (though it doesn't matter for this example).
In Fortran modes, use the floating suffix for literal integrals larger than 2^31-1. See vermaseren#546
|
Rebased and comment improved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supposed to be a "minimal" fix of #546 , in that it fixes the printing of literals
> 2^31-1in fortran modes by adding the float suffix. It does not change the C mode, nor introduce any user-configurable parameter to choose a value.There are two more differences w.r.t master, so in some sense it is not an entirely "minimal" fix. Maybe someone has some comments:
fortran90mode, the master branch adds a "." unconditionally, also to integers< 2^31-1. This PR doesn't do this, it prints them in the same way asfortranmode.pfortranmode does not work properly in the master branch: it doesn't print the((one*integer)/integer)format in all cases ("test32" in the test case, for eg).Additionally, note that in 32bit FORM, the master branch starts adding floating suffixes at
2^15-1(and this PR at2^16-1).