fixed issue with warning being thrown for short switch types #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteNinjaZ
force-pushed
the
fix_short_warn
branch
from
0916ed7
to
ba95e7c
Compare
vaughnbetz
requested changes
Sep 19, 2024
| if (rr_graph.rr_switch_inf(RRSwitchId(switch_index)).type() == SwitchType::SHORT) { | ||
| num_shorts++; | ||
| continue; | ||
| } |
There was a problem hiding this comment.
With this code change, it seems I could get divide by 0 errors late in the routine if a wire is only driven by a short (e.g. it might be the second part of an L-shaped wire). CI seems to have errors, so I think there's a bug here.
|
Relaunching CI as the old logs seem to have been deleted (too old probably and got cleaned up). |
|
@WhiteNinjaZ : Can you check for the divide by zero issue above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #2712. We have had this fix on our branch of VTR for a long time, but we forgot to merge it into the master branch.
Description
This fix simply changes the if statement checking for connections between wires to include short connections.
How Has This Been Tested?
We have been running this change on our branch of VTR for a long time and on many designs with the Xilinx architecture.
Types of changes
Checklist: