[cli] Add experimental corepack support #7871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
commented
May 25, 2022
TooTallNate
reviewed
May 25, 2022
TooTallNate
reviewed
May 25, 2022
TooTallNate
reviewed
May 31, 2022
EndangeredMassa
approved these changes
May 31, 2022
|
Looks good! |
TooTallNate
reviewed
Jun 1, 2022
Co-authored-by: Nathan Rajlich <[email protected]>
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
This debug log was originally added in #7871 because corepack has no output by default. In particular, it was nice to see the first deployment was not stalled when the package manager is being installed. That being said, this gets noisy really fast because cache detections also print a log line. For example, here's a deployment that prints 3 times: ``` Detected ENABLE_EXPERIMENTAL_COREPACK=1 and "[email protected]" in package.json Running "install" command: `npm install --prefix=.. --no-audit --engine-strict=false`... 2022-07-11T18:27:00.696Z corepack Reusing [email protected] 356 packages are looking for funding Running "npm run vercel-build" 2022-07-11T18:27:06.664Z corepack Reusing [email protected] > [email protected] vercel-build > npm run buildonly && npm run build:rss 2022-07-11T18:27:07.088Z corepack Reusing [email protected] > [email protected] buildonly > next build ``` I think its best to let users add this env var themselves if they want to debug what corepack is doing, so this PR removes that environment variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for experimental corepack to
vc build.Since this is still experimental, we only enable if the env var
ENABLE_EXPERIMENTAL_COREPACK=1is set.Tests
yarn test-unit