feat: turbo info command for debugging
#9368
Open
+114
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
anthonyshew
commented
Nov 1, 2024
anthonyshew
changed the title
turbo info command for debugging
anthonyshew
commented
Nov 1, 2024
| @@ -475,9 +475,7 @@ impl Args { | |||
| } | |||
| } | |||
|
|
|||
| /// Defines the subcommands for CLI. NOTE: If we change the commands in Go, | |||
There was a problem hiding this comment.
Unrelated, but saw it mentioning Go so ✂️
NicholasLYang
requested changes
Nov 4, 2024
Comment on lines
+25
to
+33
| let package_manager = match PackageJson::load(&base.repo_root.join_component("package.json")) { | ||
| Ok(package_json) => { | ||
| match PackageManager::read_or_detect_package_manager(&package_json, &base.repo_root) { | ||
| Ok(pm) => pm.to_string(), | ||
| Err(_) => "Not found".to_owned(), | ||
| } | ||
| } | ||
| Err(_) => "Not found".to_owned(), | ||
| }; |
There was a problem hiding this comment.
Just some Rust code golf. I'd recommend manually committing this because Rustfmt will probably disagree with this formatting
Suggested change
| let package_manager = match PackageJson::load(&base.repo_root.join_component("package.json")) { | |
| Ok(package_json) => { | |
| match PackageManager::read_or_detect_package_manager(&package_json, &base.repo_root) { | |
| Ok(pm) => pm.to_string(), | |
| Err(_) => "Not found".to_owned(), | |
| } | |
| } | |
| Err(_) => "Not found".to_owned(), | |
| }; | |
| let package_manager = PackageJson::load(&base.repo_root.join_component("package.json")) | |
| .and_then(|package_json| PackageManager::read_or_detect_package_manager(&package_json, &base.repo_root)) | |
| .map_or_else(|_| "Not found".to_owned(), |pm| pm.to_string()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A command to provide debugging information for reproductions or otherwise understand a machine better. Output will look something close to this.
Testing Instructions
Try it out!