fix(release): correct ubuntu:xenial install #5898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 11 Ignored Deployments
|
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
tknickman
commented
Sep 7, 2023
| @@ -217,7 +217,7 @@ jobs: | |||
| - host: ubuntu-latest | |||
| container: ubuntu:xenial | |||
| container-options: "--platform=linux/amd64 --rm" | |||
| container-setup: "apt-get update && apt-get install -y curl musl-tools" | |||
| container-setup: "apt-get update && apt-get install -y curl musl-tools sudo" | |||
There was a problem hiding this comment.
Required because the capnproto action needs sudo, which isn't installed in the linux/amd64 xenial container. We could remove the sudo from the capnproto action, but because it's used for all linux distros this was the easier option.
| @@ -7,7 +7,7 @@ runs: | |||
| - name: "Setup capnproto for Linux" | |||
| if: runner.os == 'Linux' | |||
| shell: bash | |||
| run: sudo apt-get update && sudo apt-get install capnproto | |||
| run: sudo apt-get -y update && sudo apt-get install -y capnproto | |||
There was a problem hiding this comment.
Auto accept install prompt.
arlyon
approved these changes
Sep 7, 2023
|
Nothing in CI is testing this, going to merge it to unblock release. |
|
✅ This change can build |
Linux Benchmark for 6db8a8dClick to view benchmark
|
MacOS Benchmark for 6db8a8d
Click to view full benchmark
|
|
Windows Benchmark for 6db8a8d
Click to view full benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix capnproto action.
Validated in test action
Closes TURBO-1310