Flesh out secure_compute_network data source #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dglsparsons
requested review from
craigandrews,
kitfoster and
jarneson
as code owners
| Computed: true, | ||
| }, | ||
| "elastic_ip_addresses": schema.SetAttribute{ | ||
| Description: "A list of Elastic IP addresses.", |
There was a problem hiding this comment.
Suggested change
| Description: "A list of Elastic IP addresses.", | |
| Description: "A list of Public IP addresses.", |
Also, we should move this out of the AWS struct.
Comment on lines
+125
to
+145
| "lambda_role_arn": schema.StringAttribute{ | ||
| Description: "The ARN of the Lambda role.", | ||
| Computed: true, | ||
| }, | ||
| "security_group_id": schema.StringAttribute{ | ||
| Description: "The ID of the security group.", | ||
| Computed: true, | ||
| }, | ||
| "stack_id": schema.StringAttribute{ | ||
| Description: "The ID of the CloudFormation stack.", | ||
| Computed: true, | ||
| }, | ||
| "subnet_ids": schema.SetAttribute{ | ||
| Description: "A list of subnet IDs.", | ||
| Computed: true, | ||
| ElementType: types.StringType, | ||
| }, | ||
| "subscription_arn": schema.StringAttribute{ | ||
| Description: "The ARN of the subscription.", | ||
| Computed: true, | ||
| }, |
There was a problem hiding this comment.
We should actually remove the disclosure of these properties from the API, they're not sensitive, but also not useful to the customer.
Suggested change
| "lambda_role_arn": schema.StringAttribute{ | |
| Description: "The ARN of the Lambda role.", | |
| Computed: true, | |
| }, | |
| "security_group_id": schema.StringAttribute{ | |
| Description: "The ID of the security group.", | |
| Computed: true, | |
| }, | |
| "stack_id": schema.StringAttribute{ | |
| Description: "The ID of the CloudFormation stack.", | |
| Computed: true, | |
| }, | |
| "subnet_ids": schema.SetAttribute{ | |
| Description: "A list of subnet IDs.", | |
| Computed: true, | |
| ElementType: types.StringType, | |
| }, | |
| "subscription_arn": schema.StringAttribute{ | |
| Description: "The ARN of the subscription.", | |
| Computed: true, | |
| }, |
Comment on lines
+95
to
+99
| "availability_zone_ids": schema.SetAttribute{ | ||
| Description: "A set of AWS Availability Zone IDs where the Secure Compute Network resources are deployed.", | ||
| Computed: true, | ||
| ElementType: types.StringType, | ||
| }, |
There was a problem hiding this comment.
This should be in the AWS struct.
This will be useful in the future for getting the ID of a network and being able to associate it with projects. Plus, there may be use-cases where getting the AWS IDs, or regions, etc. is useful.
dglsparsons
force-pushed
the
dgls/ec-3387-actually-something-that-came-up-during-hellofreshs-call
branch
from
6dc37a9 to
411c12b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful in the future for getting the ID of a network and
being able to associate it with projects.
Plus, there may be use-cases where getting the AWS IDs, or regions, etc.
is useful.