feat: supports reloading beforeSend for next/react/remix #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@testing-library/[email protected], npm/@testing-library/[email protected], npm/@types/[email protected] |
tobiaslins
approved these changes
Nov 7, 2024
| rerender(<SpeedInsights beforeSend={beforeSend} />); | ||
| expect(window.siq).toHaveLength(0); | ||
|
|
||
| rerender(<SpeedInsights beforeSend={beforeSend2} />); |
There was a problem hiding this comment.
thank you for the testing!!
| @@ -8,6 +8,10 @@ export function SpeedInsights( | |||
| framework?: string; | |||
| }, | |||
| ): JSX.Element | null { | |||
| useEffect(() => { | |||
| window.si?.('beforeSend', props.beforeSend); | |||
There was a problem hiding this comment.
nit: should we only set if its not undefined?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖖 What's in there?
Supports updating
beforeSendin next/react/remix components.🤺 How to test?
I made some unit tests for this.
🔬Notes to reviewers
We don't think it worth supporting this with astro/sveltekit/vue/nuxt. Let's wait for use cases first.