fix: consistent text positioning when embedFont is false#723
Open
privatenumber wants to merge 1 commit intovercel:mainfrom
Open
fix: consistent text positioning when embedFont is false#723privatenumber wants to merge 1 commit intovercel:mainfrom
privatenumber wants to merge 1 commit intovercel:mainfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
embedFont: false, consecutive<text>elements have inconsistentxpositions, causing uneven spacing between words. This is especially noticeable in multi-line text where gaps can accumulate to over 1px." "(space)"behavior"Root Cause
Two issues in
src/text/index.ts:leftOffset = Math.round(leftOffset)rounds x positions to integers while widths remain fractionalmeasureGrapheme()on multi-character strings usesgetAdvanceWidth()(includes kerning), butcurrentWidthaccumulates usingmeasureText()(sum of individual graphemes)Changes
leftOffsetwhenembedFont: true(paths benefit from pixel alignment)measureText()for multi-character strings whenembedFont: falseto match position accumulationTest
Added
test/embed-font.test.tsxthat verifies consecutive text elements have consistent x positions (gap < 0.01px).