feat(network firewall): align to new naming convention for network policies #33
+368
−182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licies Signed-off-by: Valerian Roche <valerian.roche@vercel.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
robherley
reviewed
Feb 3, 2026
robherley
reviewed
Feb 3, 2026
valerian-roche
force-pushed
the
vr/mode
branch
from
ad6270f to
93079d4
Compare
valerian-roche
force-pushed
the
vr/mode
branch
from
93079d4 to
1200d89
Compare
Collaborator
|
Can we also have a changeset here? |
AndyW22
approved these changes
Feb 6, 2026
QuiiBz
approved these changes
Feb 6, 2026
robherley
reviewed
Feb 9, 2026
QuiiBz
approved these changes
Feb 9, 2026
robherley
approved these changes
Feb 9, 2026
robherley
reviewed
Feb 9, 2026
robherley
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify comprehension, and towards future evolution, this commit updates the network policy naming convention:
allow-all(default) anddeny-allare made simpler, as top-level definitionsinternet-accessis notallow-all, making it more explicit that it might allow private network in the futureno-accessis nowdeny-all, as a direct mirror of the renaming ofinternet-access. It also makes it more obvious that it blocks everything, including DNS and ICMPrestrictedis now simply a structure with restrictions. It keeps the functional meaning of "denied by default"