[metadata] Move metadata rendering adjacent to page component

[huozhi]

No description provided.

[huozhi]

• [metadata] Move metadata rendering adjacent to page component #74262 👈 (View in Graphite)
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ijjk]

Failing test suites

Commit: d5faffc

pnpm test-start-turbo test/e2e/app-dir/ppr-navigations/simple/per-segment-prefetching.test.ts (turbopack)

• per segment prefetching > basic route tree prefetch

Expand output

● per segment prefetching › basic route tree prefetch

expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  1:"$Sreact.fragment"
  2:I["[project]/node_modules/.pnpm/next@file+..+next-repo-4ac15610c41873286d7c556d2d07d57a9a9f4068a01b6a9f840bb27a19407e51+packa_um3gknt3p23ajmtmsowams7w3m/node_modules/next/dist/client/components/layout-router.js [app-client] (ecmascript)",["static/chunks/dcd78_next_dist_6c5909._.js","static/chunks/app_layout_jsx_2f01b8._.js"],"default"]
  3:I["[project]/node_modules/.pnpm/next@file+..+next-repo-4ac15610c41873286d7c556d2d07d57a9a9f4068a01b6a9f840bb27a19407e51+packa_um3gknt3p23ajmtmsowams7w3m/node_modules/next/dist/client/components/render-from-template-context.js [app-client] (ecmascript)",["static/chunks/dcd78_next_dist_6c5909._.js","static/chunks/app_layout_jsx_2f01b8._.js"],"default"]
  4:I["[project]/node_modules/.pnpm/next@file+..+next-repo-4ac15610c41873286d7c556d2d07d57a9a9f4068a01b6a9f840bb27a19407e51+packa_um3gknt3p23ajmtmsowams7w3m/node_modules/next/dist/lib/metadata/metadata-boundary.js [app-client] (ecmascript)",["static/chunks/dcd78_next_dist_6c5909._.js","static/chunks/app_layout_jsx_2f01b8._.js"],"MetadataBoundary"]
- 0:{"buildId":"hTTZVGlLxNJU9TRBKGmlo","rsc":["$","$1","c",{"children":[[["$","script","script-0",{"src":"/_next/static/chunks/dcd78_next_dist_6c5909._.js","async":true}],["$","script","script-1",{"src":"/_next/static/chunks/app_layout_jsx_2f01b8._.js","async":true}]],["$","$L2",null,{"parallelRouterKey":"children","template":["$","$L3",null,{}],"notFound":[[["$","$1","h",{"children":["$","$L4","zGqAH312YFVKqsjvd8367",{"children":[]}]}]],[],[["$","title",null,{"children":"404: This page could not be found."}],["$","div",null,{"style":{"fontFamily":"system-ui,\"Segoe UI\",Roboto,Helvetica,Arial,sans-serif,\"Apple Color Emoji\",\"Segoe UI Emoji\"","height":"100vh","textAlign":"center","display":"flex","flexDirection":"column","alignItems":"center","justifyContent":"center"},"children":["$","div",null,{"children":[["$","style",null,{"dangerouslySetInnerHTML":{"__html":"body{color:#000;background:#fff;margin:0}.next-error-h1{border-right:1px solid rgba(0,0,0,.3)}@media (prefers-color-scheme:dark){body{color:#fff;background:#000}.next-error-h1{border-right:1px solid rgba(255,255,255,.3)}}"}}],["$","h1",null,{"className":"next-error-h1","style":{"display":"inline-block","margin":"0 20px 0 0","padding":"0 23px 0 0","fontSize":24,"fontWeight":500,"verticalAlign":"top","lineHeight":"49px"},"children":404}],["$","div",null,{"style":{"display":"inline-block"},"children":["$","h2",null,{"style":{"fontSize":14,"fontWeight":400,"lineHeight":"49px","margin":0},"children":"This page could not be found."}]}]]}]}]]]}]]}],"loading":null,"isPartial":true}
+ 0:{"buildId":"hTTZVGlLxNJU9TRBKGmlo","rsc":["$","$1","c",{"children":[[["$","script","script-0",{"src":"/_next/static/chunks/dcd78_next_dist_6c5909._.js","async":true}],["$","script","script-1",{"src":"/_next/static/chunks/app_layout_jsx_2f01b8._.js","async":true}]],["$","$L2",null,{"parallelRouterKey":"children","template":["$","$L3",null,{}],"notFound":[[["$","$1","h",{"children":["$","$L4","O5B3kerF7XsY3_oOH-2bL",{"children":[]}]}]],[],[["$","title",null,{"children":"404: This page could not be found."}],["$","div",null,{"style":{"fontFamily":"system-ui,\"Segoe UI\",Roboto,Helvetica,Arial,sans-serif,\"Apple Color Emoji\",\"Segoe UI Emoji\"","height":"100vh","textAlign":"center","display":"flex","flexDirection":"column","alignItems":"center","justifyContent":"center"},"children":["$","div",null,{"children":[["$","style",null,{"dangerouslySetInnerHTML":{"__html":"body{color:#000;background:#fff;margin:0}.next-error-h1{border-right:1px solid rgba(0,0,0,.3)}@media (prefers-color-scheme:dark){body{color:#fff;background:#000}.next-error-h1{border-right:1px solid rgba(255,255,255,.3)}}"}}],["$","h1",null,{"className":"next-error-h1","style":{"display":"inline-block","margin":"0 20px 0 0","padding":"0 23px 0 0","fontSize":24,"fontWeight":500,"verticalAlign":"top","lineHeight":"49px"},"children":404}],["$","div",null,{"style":{"display":"inline-block"},"children":["$","h2",null,{"style":{"fontSize":14,"fontWeight":400,"lineHeight":"49px","margin":0},"children":"This page could not be found."}]}]]}]}]]]}]]}],"loading":null,"isPartial":true}
  ↵

  54 |     const frResponse = await prefetch('/fr', '/')
  55 |     const frResponseText = await frResponse.text()
> 56 |     expect(enResponseText).toEqual(frResponseText)
     |                            ^
  57 |   })
  58 |
  59 |   it('respond with 204 if the segment does not have prefetch data', async () => {

  at Object.toEqual (e2e/app-dir/ppr-navigations/simple/per-segment-prefetching.test.ts:56:28)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev-turbo test/development/acceptance-app/hydration-error.test.ts (turbopack)

• Error overlay for hydration errors in App router > should show correct hydration error when server renders an extra whitespace in an invalid place
• Error overlay for hydration errors in App router > should collapse and uncollapse properly when there are many frames

Expand output

● Error overlay for hydration errors in App router › should show correct hydration error when server renders an extra whitespace in an invalid place

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `Error overlay for hydration errors in App router should show correct hydration error when server renders an extra whitespace in an invalid place 1`

- Snapshot  - 0
+ Received  + 1

@@ -10,10 +10,11 @@
                <HTTPAccessFallbackBoundary notFound={[...]} forbidden={undefined} unauthorized={undefined}>
                  <HTTPAccessFallbackErrorBoundary pathname="/" notFound={[...]} forbidden={undefined} ...>
                    <RedirectBoundary>
                      <RedirectErrorBoundary router={{...}}>
                        <InnerLayoutRouter url="/" tree={[...]} cacheNode={{lazyData:null, ...}} segmentPath={[...]}>
+                         <__next_metadata_boundary__>
                          <ClientPageRoot Component={function Page} searchParams={{}} params={{}}>
                            <Page params={Promise} searchParams={Promise}>
  >                           <table>
  >                             {" "}
                                ...

  425 |     expect(await getRedboxTotalErrorCount(browser)).toBe(1)
  426 |
> 427 |     expect(await session.getRedboxDescription()).toMatchInlineSnapshot(`
      |                                                  ^
  428 |      "In HTML, whitespace text nodes cannot be a child of <table>. Make sure you don't have any extra whitespace between tags on each line of your source code.
  429 |      This will cause a hydration error.
  430 |

  at Object.toMatchInlineSnapshot (development/acceptance-app/hydration-error.test.ts:427:50)

● Error overlay for hydration errors in App router › should collapse and uncollapse properly when there are many frames

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `Error overlay for hydration errors in App router should collapse and uncollapse properly when there are many frames 2`

- Snapshot  - 12
+ Received  + 13

  "...
    <HTTPAccessFallbackErrorBoundary pathname="/" notFound={[...]} forbidden={undefined} unauthorized={undefined} ...>
      <RedirectBoundary>
        <RedirectErrorBoundary router={{...}}>
          <InnerLayoutRouter url="/" tree={[...]} cacheNode={{lazyData:null, ...}} segmentPath={[...]}>
-           <ClientPageRoot Component={function Page} searchParams={{}} params={{}}>
+           <__next_metadata_boundary__>
+             <ClientPageRoot Component={function Page} searchParams={{}} params={{}}>
-             <Page params={Promise} searchParams={Promise}>
+               <Page params={Promise} searchParams={Promise}>
-               <div>
+                 <div>
-                 <div>
+                   <div>
-                   <div>
+                     <div>
-                     <div>
+                       <div>
-                       <Mismatch>
+                         <Mismatch>
-                         <p>
+                           <p>
-                           <span>
+                             <span>
-                             ...
+                               ...
- +                            client
+ +                              client
- -                            server"
+ -                              server"

  887 |     const fullPseudoHtml = await session.getRedboxComponentStack()
  888 |     if (isTurbopack) {
> 889 |       expect(fullPseudoHtml).toMatchInlineSnapshot(`
      |                              ^
  890 |        "...
  891 |          <HTTPAccessFallbackErrorBoundary pathname="/" notFound={[...]} forbidden={undefined} unauthorized={undefined} ...>
  892 |            <RedirectBoundary>

  at Object.toMatchInlineSnapshot (development/acceptance-app/hydration-error.test.ts:889:30)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js huozhi/12-23-_move_metadata_render	Change
buildDuration	22s	20.3s	N/A
buildDurationCached	19.1s	16.4s	N/A
nodeModulesSize	416 MB	416 MB	⚠️ +25 kB
nextStartRea..uration (ms)	546ms	528ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js huozhi/12-23-_move_metadata_render	Change
1187-HASH.js gzip	52.4 kB	52.4 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.36 kB	5.36 kB	N/A
bccd1874-HASH.js gzip	52.8 kB	52.8 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	232 B	235 B	N/A
main-HASH.js gzip	34.1 kB	34.1 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js huozhi/12-23-_move_metadata_render	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js huozhi/12-23-_move_metadata_render	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.49 kB	4.49 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.34 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js huozhi/12-23-_move_metadata_render	Change
_buildManifest.js gzip	749 B	746 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js huozhi/12-23-_move_metadata_render	Change
index.html gzip	522 B	524 B	N/A
link.html gzip	537 B	538 B	N/A
withRouter.html gzip	518 B	520 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js huozhi/12-23-_move_metadata_render	Change
edge-ssr.js gzip	128 kB	128 kB	N/A
page.js gzip	206 kB	206 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js huozhi/12-23-_move_metadata_render	Change
middleware-b..fest.js gzip	669 B	664 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.2 kB	31.2 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js huozhi/12-23-_move_metadata_render	Change
274-experime...dev.js gzip	322 B	322 B	✓
274.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	359 kB	359 kB	N/A
app-page-exp..prod.js gzip	129 kB	129 kB	N/A
app-page-tur..prod.js gzip	142 kB	142 kB	N/A
app-page-tur..prod.js gzip	137 kB	138 kB	N/A
app-page.run...dev.js gzip	347 kB	347 kB	N/A
app-page.run..prod.js gzip	125 kB	125 kB	N/A
app-route-ex...dev.js gzip	37.5 kB	37.5 kB	✓
app-route-ex..prod.js gzip	25.5 kB	25.5 kB	✓
app-route-tu..prod.js gzip	25.5 kB	25.5 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	39.2 kB	39.2 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.6 kB	11.6 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.7 kB	21.7 kB	✓
pages.runtim...dev.js gzip	27.5 kB	27.5 kB	✓
pages.runtim..prod.js gzip	21.7 kB	21.7 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	✓
Overall change	1.2 MB	1.2 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js huozhi/12-23-_move_metadata_render	Change
0.pack gzip	2.08 MB	2.08 MB	⚠️ +4.51 kB
index.pack gzip	73.9 kB	73.3 kB	N/A
Overall change	2.08 MB	2.08 MB	⚠️ +4.51 kB

Diff details

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Commit: d5faffc