Safely retrieve router, improve page reload logic #74209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR improves the hot module reloading (HMR) logic in the dev client by: - Safe Router Retrieval: Uses optional chaining (window.next?.router) to prevent errors if the router is uninitialized. - Enhanced Error Page Handling: Ensures the client reloads when on /404 or /_error pages, addressing cases where page additions/removals can't be reliably matched to the current path. - Improved Reload Logic: Checks if the current page is added or removed and triggers a reload accordingly to keep the client state up-to-date. - Updated Comments: Clarifies the conditions under which reloads occur, especially when on error pages. These changes make the HMR process more robust and prevent potential runtime issues. Closes vercel#71974
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the hot module reloading (HMR) logic in the dev client by:
These changes make the HMR process more robust and prevent potential runtime issues.
Closes #71974