Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use latest version of pnpm #37794

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Update to use latest version of pnpm #37794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3301850
Update to use latest version of pnpm
ijjk Jun 17, 2022
c4ab8bf
Merge branch 'canary' into update/pnpm-version
ijjk Jun 17, 2022
950d9ca
add packageManager field
ijjk Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/next-stats-action/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ LABEL repository="https://github.com/vercel/next-stats-action"
COPY . /next-stats

# Install node_modules
RUN npm i -g pnpm@7.1.6
RUN npm i -g pnpm@7.2.1
RUN cd /next-stats && pnpm install --production

RUN git config --global user.email 'stats@localhost'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_test_deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ env:
NAPI_CLI_VERSION: 2.7.0
TURBO_VERSION: 1.2.14
RUST_TOOLCHAIN: nightly-2022-02-23
PNPM_VERSION: 7.1.6
PNPM_VERSION: 7.2.1

jobs:
check-examples:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull_request_stats.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ env:
NAPI_CLI_VERSION: 2.7.0
TURBO_VERSION: 1.2.14
RUST_TOOLCHAIN: nightly-2022-02-23
PNPM_VERSION: 7.1.6
PNPM_VERSION: 7.2.1

jobs:
build-native-dev:
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ pr:

variables:
PNPM_CACHE_FOLDER: $(Pipeline.Workspace)/.pnpm-store
PNPM_VERSION: 7.1.6
PNPM_VERSION: 7.2.1
NEXT_TELEMETRY_DISABLED: '1'
node_version: ^14.19.0

Expand Down
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@
},
"engines": {
"node": ">=12.22.0",
"pnpm": "7"
}
"pnpm": ">= 7.2.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add packageManager to package.json?

https://nodejs.org/api/packages.html#packagemanager

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any downsides to using packageManager? Seems it's still experimental

Copy link
Member

@styfle styfle Jun 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its opt-in so any downsides won't be noticed unless the user enabled corepack.

The biggest downside I found is this nodejs/corepack#112

I think its worth trying out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok if it's still opt-in sounds alright to test out, added in 950d9ca

},
"packageManager": "[email protected]"
}