Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (ai/core): throw NoImageGeneratedError from generateImage when no predictions are returned #4395

Merged
merged 13 commits into from
Jan 23, 2025
Merged

feat (ai/core): throw NoImageGeneratedError from generateImage when no predictions are returned #4395

merged 13 commits into from
Jan 23, 2025

Conversation

shaper
Copy link
Contributor

@shaper shaper commented Jan 14, 2025 •
edited
Loading

  • ai: added ImageModelMetadataResponse and NoImageGeneratedError
  • note we do not have an id for image model requests
  • newly tracks the start-response-timestamp for reporting in the error

@shaper shaper changed the title feat (provider/google-vertex): throw error detail when no predictions are returned. feat (provider/google-vertex): throw error detail in generateImage when no predictions are returned. Jan 14, 2025
@shaper shaper marked this pull request as ready for review January 14, 2025 21:58
@shaper shaper requested a review from lgrammel January 14, 2025 21:59
@shaper shaper force-pushed the shaper/pr/vertex-image-empty-response branch from 02e51a9 to 671ab95 Compare January 18, 2025 01:33
@shaper shaper force-pushed the shaper/pr/vertex-image-empty-response branch from 39800ab to 6c60462 Compare January 21, 2025 22:20
@shaper shaper changed the title feat (provider/google-vertex): throw error detail in generateImage when no predictions are returned. feat (ai/core): throw NoImageGeneratedError from generateImage when no predictions are returned. Jan 21, 2025
@shaper shaper changed the title feat (ai/core): throw NoImageGeneratedError from generateImage when no predictions are returned. feat (ai/core): throw NoImageGeneratedError from generateImage when no predictions are returned Jan 21, 2025
@shaper shaper force-pushed the shaper/pr/vertex-image-empty-response branch from 6cb3652 to 6283271 Compare January 21, 2025 23:07
@shaper shaper force-pushed the shaper/pr/vertex-image-empty-response branch from f619e13 to a64e947 Compare January 23, 2025 01:49
@lgrammel lgrammel merged commit 3a58a2e into main Jan 23, 2025
9 checks passed
@lgrammel lgrammel deleted the shaper/pr/vertex-image-empty-response branch January 23, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgrammel lgrammel lgrammel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaper @lgrammel