Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support generate id from server side #3110

Closed
wants to merge 3 commits into from
Closed

feat: support generate id from server side #3110

wants to merge 3 commits into from

Conversation

himself65
Copy link
Contributor

Fixes: #3061

himself65
himself65 commented Sep 24, 2024
View reviewed changes
Copy link
Contributor Author

@himself65 himself65 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look, if overall looks good I will continue on adding tests&example

/cc @lgrammel

@himself65 himself65 force-pushed the himself65/20240924/id branch from ac6ae25 to 1c18e5f Compare September 24, 2024 18:17
@lgrammel
Copy link
Collaborator

lgrammel commented Sep 25, 2024 •
edited
Loading

Hi thanks for taking a look at this. It would need to support multiple messages in the same stream, e.g. for multi-step tool calls. I was considering either adding it to the finishStepPart or adding a startStepPart - but it also needs some thinking regarding the mapping of steps to messages, and what objects would need ids and when.

How would you send the ids from streamText?

@lgrammel
Copy link
Collaborator

Superseeded by #4415

@lgrammel lgrammel closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generate assistant message id from backend side
2 participants
@himself65 @lgrammel