Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field's merge support #193

Open
wants to merge 1 commit into
base: craft-5
Choose a base branch
from

Conversation

mikolamin
Copy link

Accordign to add merge field PR.
There’s a new MergeableFieldInterface, which field types must implement to opt into being mergeable.

@engram-design
Copy link
Member

I've not looked into this yet, but is this a completed solution and tested? I was under the impression that we'd need to provide migration handling as per Brandon's write-up?

@mikolamin
Copy link
Author

mikolamin commented Sep 12, 2024

In my case migration was successful with this changes, but during it I turned off comparing the field settings in the fields/merge script due to the fact that Hyper fields always have differern setting in the config file.

@engram-design
Copy link
Member

Gotcha, I'll be looking into that as well as the same time as I tackle this. We're planning on cleaning up the field settings a bit with the field layouts.

@mikolamin
Copy link
Author

Thanks, looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants