Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidity test - with signature test - working #59

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

jac18281828
Copy link
Collaborator

Delegate and Attribute complete
closes #56

This PR introduces comprehensive testing in Solidity for the did-eth-registry. By consolidating our tests within a single high-performance Solidity framework, we simplify future improvements and refactoring efforts. This approach also eliminates the need to switch between different language implementations, streamlining our development process.

Delegate and Attribute complete
closes veramolabs#56
Copy link
Contributor

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still reviewing. It's a massive change so it will take a while longer :/
I decided to share some of my notes as I might be misunderstanding some things (I haven't used foundry before).

Copy link
Contributor

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!
I think it's a solid foundation to build further features.

@mirceanis mirceanis merged commit 228ecc4 into veramolabs:main Oct 17, 2023
1 check passed
@jac18281828 jac18281828 deleted the jac/test branch October 17, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support EVM emulation and Solidity based testing (Foundry RS)
2 participants