Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar for english language #2383

Closed
wants to merge 1 commit into from
Closed

Conversation

Diacius
Copy link
Contributor

@Diacius Diacius commented May 6, 2023

Make a few tweaks so that the English language version is more accurate and flows better.

Make a few tweaks so that the English language version is more accurate and flows better.
@Diacius
Copy link
Contributor Author

Diacius commented Jun 22, 2023

@ventoy is it possible to merge this?

@wiz64
Copy link
Contributor

wiz64 commented Jun 26, 2023

🤣 looks like you're writing a journal

@Diacius
Copy link
Contributor Author

Diacius commented Jun 26, 2023

what?

@wiz64
Copy link
Contributor

wiz64 commented Jun 27, 2023

what?

i don't feel that many of the changes are really better.
in > on ..
"STR_VTSI_CREATE_TIP" : we ? or ventoy ?
overall i think current translations are fine, and like they don't really need to be changed.

@Diacius
Copy link
Contributor Author

Diacius commented Jun 27, 2023

Fair enough, some of the changes are little pedantic. But I think that my version flows better and does make the messages in the app easier to read, its not like it's loads of effort for me to make these changes, its usually more effort to get the pull request merged!

@wiz64
Copy link
Contributor

wiz64 commented Jun 28, 2023

well, let longpanda decide :-)

@Diacius
Copy link
Contributor Author

Diacius commented Apr 9, 2024

I have created a new pull request with updated translations #2803

@Diacius Diacius closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants