feat: Error message for nonexistent mocks #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LandonTClipp
approved these changes
Jan 31, 2025
Comment on lines
+227
to
+244
| func (p *Parser) Has(packageName, interfaceName string) bool { | ||
| for _, entry := range p.files { | ||
| if entry.pkg.PkgPath != packageName { | ||
| continue | ||
| } | ||
|
|
||
| for _, ifaceName := range entry.interfaces { | ||
| if ifaceName != interfaceName { | ||
| continue | ||
| } | ||
|
|
||
| return true | ||
| } | ||
| } | ||
|
|
||
| return false | ||
| } | ||
|
|
There was a problem hiding this comment.
This is good, obviously this is a polynomial runtime because of the linear iteration through all interfaces during each query, but it's probably fine? Simple is good 👍🏻
There was a problem hiding this comment.
I know this is far from optimal, but since the parser stores entries as a slice, I don't think creating an additional map for that specific (and only) case is needed. (But could be done, feel free to ping me).
I hope nobody has tens of thousands of interfaces in a single project :D
LandonTClipp
added a commit
to LandonTClipp/mockery
that referenced
this pull request
Feb 1, 2025
PR vektra#907 used a feature of zerolog that did not exist in the version mockery depended on. It's still a mystery how CICD allowed this to happen, but I will release this fix before that investigation is complete.
LandonTClipp
added a commit
that referenced
this pull request
Feb 1, 2025
PR #907 used a feature of zerolog that did not exist in the version mockery depended on. It's still a mystery how CICD allowed this to happen, but I will release this fix before that investigation is complete.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a log message that warns user that he specified an interface that doesn't exist.
I did add an extra
Hasfunction for parser because main loop shouldn't have that kind of logic, given that parser already parsed the interfaces and has all the metainfo for them.I also decided to not add any flags because it seems like something that shouldn't be turned off as a separate feature, but it's still possible to set
log-level = errorand remove this for those who want it.Please let me know if I missed something! I will also do a PR for
v3after this one will be accepted.Type of change
Version of Go used when building/testing:
How Has This Been Tested?
There's only one log message that was added, I'm know sure how/if we should test it. I can add tests for parser.Has, if needed, but the function itself is pretty simple.
Checklist