Skip to content

Commit

Permalink
Update, migrate, improve log help links
Browse files Browse the repository at this point in the history
  • Loading branch information
vegegoku committed Jan 9, 2025
1 parent e71147c commit 0d70267
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 170 deletions.
4 changes: 2 additions & 2 deletions dev/core/src/com/google/gwt/dev/DevMode.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
import com.google.gwt.dev.shell.jetty.JettyLauncher;
import com.google.gwt.dev.ui.RestartServerCallback;
import com.google.gwt.dev.ui.RestartServerEvent;
import com.google.gwt.dev.util.InstalledHelpInfo;
import com.google.gwt.dev.util.GwtprojectOrgHelpInfo;
import com.google.gwt.dev.util.Util;
import com.google.gwt.dev.util.arg.ArgHandlerDeployDir;
import com.google.gwt.dev.util.arg.ArgHandlerExtraDir;
Expand Down Expand Up @@ -723,7 +723,7 @@ private void validateServletTags(TreeLogger logger, ServletValidator servletVali

TreeLogger servletLogger =
logger.branch(TreeLogger.DEBUG, "Validating <servlet> tags for module '" + module.getName()
+ "'", null, new InstalledHelpInfo("servletMappings.html"));
+ "'", null, new GwtprojectOrgHelpInfo("/doc/latest/gwt-dev-help/servletMappings.html"));
for (String servletPath : servletPaths) {
String servletClass = module.findServletForPath(servletPath);
assert (servletClass != null);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
package com.google.gwt.dev.javac;

import com.google.gwt.dev.jdt.SafeASTVisitor;
import com.google.gwt.dev.util.InstalledHelpInfo;
import com.google.gwt.dev.util.GwtprojectOrgHelpInfo;
import com.google.gwt.dev.util.collect.Stack;

import org.eclipse.jdt.core.compiler.CharOperation;
Expand All @@ -43,16 +43,14 @@
* Check a compilation unit for violations of
* {@link com.google.gwt.core.client.JavaScriptObject JavaScriptObject} (JSO)
* restrictions. The restrictions are summarized in
* <code>jsoRestrictions.html</code>.
*
*
* @see <a href="https://www.gwtproject.org/doc/latest/DevGuideCodingBasicsJSNI.html">jsoRestrictions.html</a>.
* Any violations found are attached as errors on the
* CompilationUnitDeclaration.
*
* @see <a
* href="http://code.google.com/p/google-web-toolkit/wiki/OverlayTypes">Overlay
* types design doc</a>
* @see jsoRestrictions.html
* @see <a href="https://www.gwtproject.org/doc/latest/DevGuideCodingBasicsJSNI.html">jsoRestrictions.html</a>
*/
public class JSORestrictionsChecker {

Expand Down Expand Up @@ -288,8 +286,8 @@ static String errAlreadyImplemented(String intfName, String impl1,

private static void errorOn(ASTNode node, CompilationUnitDeclaration cud,
String error) {
GWTProblem.recordError(node, cud, error, new InstalledHelpInfo(
"jsoRestrictions.html"));
GWTProblem.recordError(node, cud, error, new GwtprojectOrgHelpInfo(
"/doc/latest/DevGuideCodingBasicsJSNI.html"));
}

private final CompilationUnitDeclaration cud;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import com.google.gwt.dev.js.ast.JsFunction;
import com.google.gwt.dev.js.ast.JsModVisitor;
import com.google.gwt.dev.js.ast.JsNameRef;
import com.google.gwt.dev.util.InstalledHelpInfo;
import com.google.gwt.dev.util.GwtprojectOrgHelpInfo;
import com.google.gwt.dev.util.JsniRef;
import com.google.gwt.dev.util.collect.Stack;
import com.google.gwt.thirdparty.guava.common.collect.Lists;
Expand Down Expand Up @@ -824,8 +824,8 @@ private boolean isUnsafeLongAnnotation(Annotation annot, ClassScope scope) {
}

private void longAccessError(ASTNode node, String message) {
GWTProblem.recordError(node, cud, message, new InstalledHelpInfo(
"longJsniRestriction.html"));
GWTProblem.recordError(node, cud, message, new GwtprojectOrgHelpInfo(
"/doc/latest/gwt-dev-help/longJsniRestriction.html"));
}

private static void resolveJsniRef(JsniRef jsniRef, FieldBinding fieldBinding) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import com.google.gwt.core.ext.ServletContainerLauncher;
import com.google.gwt.core.ext.TreeLogger;
import com.google.gwt.core.ext.UnableToCompleteException;
import com.google.gwt.dev.util.InstalledHelpInfo;
import com.google.gwt.dev.util.GwtprojectOrgHelpInfo;
import com.google.gwt.dev.util.Util;
import com.google.gwt.thirdparty.guava.common.collect.Iterators;
import com.google.gwt.thirdparty.guava.common.collect.Lists;
Expand Down Expand Up @@ -447,7 +447,7 @@ private boolean addContainingClassPathEntry(String warnMessage,
}
branch = branch.branch(logLevel, "Adding classpath entry '"
+ classPathURL + "' to the web app classpath for this session",
null, new InstalledHelpInfo("webAppClassPath.html"));
null, new GwtprojectOrgHelpInfo("/doc/latest/gwt-dev-help/webAppClassPath.html"));
try {
addClassPath(classPathURL);
return true;
Expand Down
54 changes: 0 additions & 54 deletions distro-source/core/src/doc/helpInfo/jsoRestrictions.html

This file was deleted.

42 changes: 0 additions & 42 deletions distro-source/core/src/doc/helpInfo/longJsniRestriction.html

This file was deleted.

21 changes: 0 additions & 21 deletions distro-source/core/src/doc/helpInfo/servletMappings.html

This file was deleted.

39 changes: 0 additions & 39 deletions distro-source/core/src/doc/helpInfo/webAppClassPath.html

This file was deleted.

0 comments on commit 0d70267

Please sign in to comment.