Skip to content

Conversation

@stephengtuggy
Copy link
Contributor

@stephengtuggy stephengtuggy commented Dec 26, 2025

Thank you for submitting a pull request and becoming a contributor to Vega Strike's Build System Docker Images.

Please answer the following:

Code Changes:

  • CI Change

Issues:

Purpose:

  • What is this pull request trying to do? Add back SDL3 and SDL3_image to the list of packages to install on Fedora 42 and 43, which somehow got lost in the shuffle sometime in the last few weeks. Also add back the logic that uninstalls non-SDL3-based (non-"compat") SDL2 from Rocky Linux 10.0 and 10.1. Add the same logic for Red Hat, and for Fedora as well.
  • What release is this for? 0.10.x, primarily
  • Is there a project or milestone we should apply this to? 0.10.x?

@stephengtuggy stephengtuggy self-assigned this Dec 26, 2025
@stephengtuggy stephengtuggy added bug Something isn't working dependencies Pull requests that update a dependency file labels Dec 26, 2025
@stephengtuggy stephengtuggy moved this to In progress in 0.10.x Release Dec 26, 2025
@stephengtuggy stephengtuggy marked this pull request as ready for review December 26, 2025 23:44
Copy link
Member

@BenjamenMeyer BenjamenMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need need SDL2 on the base images for 0.9.x builds.

@stephengtuggy
Copy link
Contributor Author

We still need need SDL2 on the base images for 0.9.x builds.

For that, we'll use SDL2-compat instead, which is a compatibility layer built on top of SDL3. At least, that's what we'll use on RPM-based distros.

@BenjamenMeyer
Copy link
Member

We still need need SDL2 on the base images for 0.9.x builds.

For that, we'll use SDL2-compat instead, which is a compatibility layer built on top of SDL3. At least, that's what we'll use on RPM-based distros.

Fair enough. Let's move forward with this then

@stephengtuggy stephengtuggy merged commit d872cc6 into vegastrike:master Dec 28, 2025
34 checks passed
@stephengtuggy stephengtuggy deleted the sdl3-on-fedora branch December 28, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants