-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to na.rm in decostand methods alr/clr #667
Open
antagomir
wants to merge
12
commits into
vegandevs:master
Choose a base branch
from
antagomir:nafix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TuomasBorman
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think now works as expected. See the comments.
Great, fixed the remarks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #661
The
na.rm
option has been enabled in decostand methods "alr" and "clr".Some notes:
"clr": With
na.rm=TRUE
, the NA entries in original data are replaced by 0 in the clr-transformed data; here zero is an arbitrary choice but no better solutions are available afaik, and the same approach is used incompositions::clr
so at least we are in sync. Withna.rm=FALSE
, the entries that are NA in the original data will be also NAs in the clr-transformed data; the NAs are otherwise ignored in the calculations during the transformation. In the alternative implementation,compositions::alr
NAs are always replaced with 0 (no na.rm option available). As far as I can see it is feasible to provide both options forna.rm
for the "clr" method, we are providing that now."alr": similarly done for decostand "alr" transformation, user can choose whether to keep the NAs (
na.rm=FALSE
) or replace them by 0 (na.rm=TRUE
). In comparison, I noticed that in the alternative implementation,compositions::alr
NAs are always kept as NAs (no na.rm option available). As far as I can see it is feasible to provide both options forna.rm
for the "alr" method, we are providing that now.The "rclr" method will be handled separately in Matrix completion for robust CLR in decostand #619
@TuomasBorman can you test and confirm that these are as you expected?