Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support Chart.transform_filter(*predicates, **constraints) #3664

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

feat: Support Chart.transform_filter(*predicates, **constraints) #3664

wants to merge 24 commits into from

Commits on Oct 30, 2024

  1. chore(typing): Add temporary alias for filter

    @dangotbanned
    dangotbanned committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5bdb33d View commit details
    Browse the repository at this point in the history

  2. refactor: Make empty a regular keyword arg 

    - Not planning to keep the new body of the method
- Purely fishing for the first test failure
    @dangotbanned
    dangotbanned committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2efd5f8 View commit details
    Browse the repository at this point in the history

  3. refactor: Remove **kwargs 

    Interestingly, this doesn't break any tests,
Would indicate what I suspected in (#3657) was true
    @dangotbanned
    dangotbanned committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    d2868f8 View commit details
    Browse the repository at this point in the history

  4. docs: Add note on Predicate 

    Remember discovering this during (#3427), but hadn't documented
    @dangotbanned
    dangotbanned committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    841e887 View commit details
    Browse the repository at this point in the history

  5. feat(DRAFT): Adds _transform_filter_impl

    @dangotbanned
    dangotbanned committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    63de259 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into transform-filter-pr… 

    …edicates
    @dangotbanned
    dangotbanned committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    40146f7 View commit details
    Browse the repository at this point in the history

  7. feat: Adds transform_filter implementation 

    Includes deprecation handling
    @dangotbanned
    dangotbanned committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    c22ba58 View commit details
    Browse the repository at this point in the history

  8. fix(DRAFT): Add temp ignore for line_chart_with_cumsum_faceted 

    - Need to widen the definition of `_PredicateType`
- To support this, we'll need to model with `TypedDict`(s)
    @dangotbanned
    dangotbanned committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    fc672bc View commit details
    Browse the repository at this point in the history

  9. feat(typing): Widen _FieldEqualType to include IntoExpression 

    This alias may be redundant now, need to review that later
    @dangotbanned
    dangotbanned committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8554a46 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. fix: Try replacing Undefined first 

    Didn't account for a `TypeError` that can be triggered if `more_predicates` isn't composable.
E.g `filter={"field": "year", "oneOf": [1955, 2000]}`
    @dangotbanned
    dangotbanned committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ff9d33f View commit details
    Browse the repository at this point in the history

  2. test: Add (*predicates, **constraints) syntax tests

    @dangotbanned
    dangotbanned committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b497039 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Merge branch 'main' into transform-filter-predicates

    @dangotbanned
    dangotbanned authored Nov 2, 2024
    Configuration menu
    Copy the full SHA
    54d0cbc View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2024

  1. Merge remote-tracking branch 'upstream/main' into transform-filter-pr… 

    …edicates
    @dangotbanned
    dangotbanned committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    a375ab5 View commit details
    Browse the repository at this point in the history

  2. docs: Use *predicates in "Faceted Line Chart with Cumulative Sum" 

    Makes use of #3668

Resolves #3664 (comment)
    @dangotbanned
    dangotbanned committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    7f6c188 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Merge remote-tracking branch 'upstream/main' into transform-filter-pr… 

    …edicates
    @dangotbanned
    dangotbanned committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    0d4ff86 View commit details
    Browse the repository at this point in the history

  2. refactor: Remove _OrigFilterType

    @dangotbanned
    dangotbanned committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    be63d4e View commit details
    Browse the repository at this point in the history

  3. docs: Update .transform_filter() docstring 

    - Builds on the style introdcued for `alt.when`
- Shows a few specific kinds of predicates - due to the prior doc listing 5

#3657
    @dangotbanned
    dangotbanned committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    7a0cc42 View commit details
    Browse the repository at this point in the history

  4. docs: Minor corrections in examples

    @dangotbanned
    dangotbanned committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    08a4207 View commit details
    Browse the repository at this point in the history

  5. refactor(typing): Cast deprecated filter in one location 

    Need to forgo all type safety here, since it would permit `_PredicateType` instead of the narrower `_FieldEqualType`
    @dangotbanned
    dangotbanned committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    5fd4f5a View commit details
    Browse the repository at this point in the history

  6. refactor: Remove pred assignment 

    I added this while trying to resolve a different typing issue, purely to see what was inferred
    @dangotbanned
    dangotbanned committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d640933 View commit details
    Browse the repository at this point in the history

  7. docs(typing): Update _FieldEqualType 

    Think this makes it clearer how each of these align
    @dangotbanned
    dangotbanned committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2d57d6e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into transform-filter-predicates

    @dangotbanned
    dangotbanned authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    01571dd View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Merge branch 'main' into transform-filter-predicates

    @dangotbanned
    dangotbanned authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    10f1d1d View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Merge branch 'main' into transform-filter-predicates

    @dangotbanned
    dangotbanned authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    860e6af View commit details
    Browse the repository at this point in the history